[Phpmyadmin-devel] Little patch for little bug

[Michal Cihar]

Hi

Thanks, for mentioning this, however, it can't be inside if because if
is also for mysql_num_rows($result) > 0. Fixed in cvs (now it is file
libraries/export/sql.php3).

-- 
Regards
	Michal Cihar
	http://cihar.com

Original message (Mehdi, 15.09.2003 16:28):
> Hi all,
> 
> I've found a small bug this morning on phpMyAdmin 2.5.1 in
> build_dump.lib.php Here's an unified diff of the fix (the
> mysql_free_result() call should be inside the if statement) :
> @@ -83,8 +83,8 @@
>                      $schema_create .= '# ' .
>                      $GLOBALS['strStatCheckTime'] . ': ' .
>                      PMA_localisedDate(strtotime($tmpres['Check_time']))
>                      . $crlf;                     $new_crlf = '#' . $crlf
>                      . $crlf;                 }
> -            }
>              mysql_free_result($result);
> +            }
>          }
> 
>          $schema_create .= $new_crlf;
> 
> I've browsed the current CVS tree and this file seems to have been
> deleted, but I think the same problem is now in
> librairies/export/sql.php, line 169. Can someone fix it ?
> Cheers,
> 
> Mehdi Achour - Nexen.net