[Phpmyadmin-devel] MySQL 4.1 and column comments

[Marc Delisle]

Garvin Hicking a écrit:

> Hi Marc!
> 
> 
>>For the 4.1 column commenting, yes it would be a welcome addition.
>>I wonder if we should do like in the relation view, where we offer
>>both internal relations and InnoDB relations. Some people might already have
>>internal column comments and we have to show them, but they want to add native
>>4.1 comments. We could even do the switch ourselves.
> 
> 
> I'd vote for using the 4.1 internal structure, if available instead of our
> internal one. We'd need to abstract all calls to fetching comments to be
> replacable with a SQLquery to get column comments.

Garvin,
we already have PMA_getComments($db, $table). Did you find someplace not using
this call to fetch comments?

> There's much depending on
> column comments (like "show table aliases in left frame" option and embedding
> comments in SQL dump), so I don't think a user should be able to enter differing
> comments in our infrastructure or the MySQL one. I also don't think it's
> necessary to offer the user a switch to use either infrastructure.

By "switch" I meant this: suppose someone already has comments in pmadb. Does he have
to reenter them in the MySQL structure?
> 
> Or does anyone think there'll be a need that a user wants to store his comments
> in PMA DB instead of MySQL 4.1?
> 
> Regards,
> Garvin.
>