[Phpmyadmin-devel] Re: deglobalization started
Marc.Delisle at cegepsherbrooke.qc.ca
Sun Dec 11 14:43:01 CET 2005
Michal Čihař a écrit :
> On Sun, 11 Dec 2005 08:52:04 -0500
> Marc Delisle <Marc.Delisle at cegepsherbrooke.qc.ca> wrote:
>>please look at my commit for sql.php, revision 2.76. I have just changed
>>$goto by $_REQUEST['goto']. Is this the way we want to take?
>>It's a bit weird for me to use $_REQUEST['goto'] on the left side of an
>>assignment, but anyway tell me your comments so I can continue :)
> Yes it is weird and IMHO we should avoid it - clean up goto at start
> and put it in local namespace.
this is why in my "globals" previous message, I was asking "everywhere
in the code, replace the variables...". Everywhere means everywhere :)
I remember that in 2005-02, you were suggesting to fetch the variable
from $_REQUEST and then set it in global space, so we would be using
$goto everywhere, except for the first time in a script. This is still
Personally I would go like you suggested in 2005-02, (it's less job to
modify all the scripts, and the weird left assignment would be gone) but
I have a small regret: this way we don't see the origin of $goto.
Maybe later, we could rename all variables that come from an external
source, like $request_goto or something like that.
Anyway I'll commit the changes today or tomorrow.
More information about the Developers