[Phpmyadmin-devel] phpMyAdmin 2.6.1-pl2 is released

[Michal Čihař]

On Fri 25. 2. 2005 16:16, Marc Delisle wrote:
> Michal Čihař a écrit :
> > Side note: I'm anyway fixing phpMyAdmin for older SUSE
> > distributions, so I can provide patches for some older version if
> > wanted.
>
> Good! Can you work on patching 2.2.7-pl1 for a -pl2? Do you have a
> PHP3 system on-line to test it?

No, I fixed only 2.4.0 and several newer versions.

> > I have only slight problem with 2.4.0 and older where we used code:
> >
> >     if (!empty($_GET)) {
> >         extract($_GET, EXTR_OVERWRITE);
> >     } else if (!empty($HTTP_GET_VARS)) {
> >         extract($HTTP_GET_VARS, EXTR_OVERWRITE);
> >     } // end if
> >
> > Will it work if I change EXTR_OVERWRITE to EXTR_SKIP or do I have
> > to backport all logic from newer version?
>
> I don't remember this old code but I would say it's safer to backport
> the whole logic.

I did exactly this, it looks safer.

-- 
    Michal Čihař | http://www.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20050225/0fe0dfbd/attachment.sig>