[Phpmyadmin-devel] XHTML compliance patch, PLS TEST!
michal at cihar.com
Tue Oct 4 04:16:22 CEST 2005
On Tue 4. 10. 2005 13:04, Sebastian Mendel wrote:
> Michal Čihař wrote:
> > Hi
> > On Tue 4. 10. 2005 10:13, Sebastian Mendel wrote:
> >> i would like to commit this into CVS, if no one is against.
> > I just quickly looked at the patch, My comments follow. The all do
> > not address new code, however when the code is being touched, it
> > could be cleaned up :-). Those are just minor issues, generally I
> > like it.
> > - do not hardcode color in global css
> > - do not change error reporting
> > - you can rely on fact that all cfg parameters are set, this
> > includes PmaAbsoluteUri
> also $GLOBALS['cfg']['Bookmark']['db'] ?
If there is server selected PMA_getBookmarksParam will fill it.
Michal Čihař | http://cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
More information about the Developers