[Phpmyadmin-devel] improve listing in server_databses.php

[Marc Delisle]

Sebastian Mendel a écrit :
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Marc Delisle schrieb:
>> Sebastian Mendel a écrit :
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>>> Marc Delisle schrieb:
>>>> Sebastian Mendel a écrit :
>>>>> Hi,
>>>>>
>>>>> can you please test the server_databases.php?
>>>> Interesting!
>>>>
>>>> MySQL 5.0.18, $cfg['NaturalOrder'] set to false.
>>>>
>>>> The begin, previous, next, end work as expected, except that the page
>>>> number does not change as expected when clicking next. On first page,
>>>> click next, still on page 1. Click next, still page 1, Click next, now
>>>> on page 2. Click next, now on page 3, this is the last page.
>>>> Using the page selector, choose page 2 and I'm back to cookie login
>>>> page. Maybe $server is missing.
>>> yes, i saw this just seconds after commit .. ;-)
>>> fixed!
>> On my small server, clicking next now works correctly, except for this:
>> I click 4 times on next, so I should have 5 pages in the selector but I
>> have only 4. And on the last page, page number in the selector displays 1.

I fixed a calculation bug by adding brackets. Page number was never 
selected in the dropdown except on page 1.

>>
>> Using the page selector directly still logs me out!
>>
>>>> On the "big" server, nothing appears, mysqld is eating 98% of CPU.
>>> What is "big"?
>> 4400 databases.
>>
>>> Nothing appears? White page?
>> Browser still active, no white page, still seeing the previous page.
>>
>>> But is it now more worse than before on this Server?
>> yep.
> 
> ok, i disabled table stats by default, how now?

It works now on the big server, stats generation was really hitting hard 
the server! I believe that on a previous version, stats were disabled by 
default, it's better this way.

> 
> 
>>> Of course to test this you should call ONLY server_databases.php
>>> (without the frames)
>> When calling directly I'm logged out.
> 
> ok, this should fixed now
> 
> 

Confirmed.

Marc