[Phpmyadmin-devel] about PMA_THEME_VERSION

[Michal Čihař]

Hi all

I think this should go to -devel so I post it here :-).

On Wed, 02 Aug 2006 08:23:31 -0400
Marc Delisle <Marc.Delisle at cegepsherbrooke.qc.ca> wrote:

> I discussed with Sebastian and I would like your opinion, since 
> Sebastian and I disagree.
> 
> In the doc we say
> "Themes within same generation should be backwards compatible
> - theme with version 2 should work in phpMyAdmin requiring version 1.
> 
> Themes with different generation are incompatible."
> 
> In Config.class.php, Sebastian marked deprecated PMA_THEME_VERSION and 
> PMA_THEME_GENERATION.
> 
> In Theme.class.php, there is a checkVersion() function that
> 1. uses version_compare(), which would not give the level of 
> verification we need, and
> 2. is never used :)
> 
> Sebastian says that a user should see all the installed themes and be 
> able to choose them, even if they are not compatible; he says that a 
> user should be able to notice by himself that a theme is outdated.

I think showing all themes is sensible way to go. Otherwise if user
installs old theme, it is hard to find out what's going on. And I saw
such problem several times.

However user might not be able to notice this himself, so I'd put
warning on bottom of main.php if theme is outdated (saying that some
parts might be displayed wrongly due to too old theme).

The only problem is how to check whether theme is compatiblem.
I thought generation/version will be best solution when I wrote that
code, because I expected theme changes don't have to be with each
version...

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20060802/d0e25d86/attachment.sig>