[Phpmyadmin-devel] 2.8.2.3 breaks scripts/setup.php

[Marc Delisle]

Marc Delisle a écrit :
> Jürgen Wind a écrit :
>>
>> Marc Delisle wrote:
>>> Jürgen Wind a écrit :
>>>> Marc, lets first see, if 
>>>> $GLOBALS['PMA_Config_Setup']
>>>> is the better patch (also in line 1811)
>>> Well, many functions in setup.php are using
>>>
>>> global $PMA_Config_Setup;
>>>
>>> and then
>>> $PMA_Config_Setup->something
>>>
>>> I think this would be more consistent.
>>>
>>> Marc
> 
>> and why
>> $GLOBALS['PMA_Config_Setup']->get (2 occurrences)
>> and not
>> $PMA_Config_Setup->get (many occurrences) ?
> 
> This was my question to Michal in the devel-list...
> 
> But I think it's safe to merge my latest suggestion.
> 
> Marc

Well, at this point we are already in the global context, no need for 
"global ..." .

This should be safe, checking the PHP version is checking the PHP version :)

Marc