[Phpmyadmin-devel] 22.214.171.124 breaks scripts/setup.php
Marc.Delisle at cegepsherbrooke.qc.ca
Tue Aug 22 19:27:14 CEST 2006
Marc Delisle a écrit :
> Jürgen Wind a écrit :
>> Marc Delisle wrote:
>>> Jürgen Wind a écrit :
>>>> Marc, lets first see, if
>>>> is the better patch (also in line 1811)
>>> Well, many functions in setup.php are using
>>> global $PMA_Config_Setup;
>>> and then
>>> I think this would be more consistent.
>> and why
>> $GLOBALS['PMA_Config_Setup']->get (2 occurrences)
>> and not
>> $PMA_Config_Setup->get (many occurrences) ?
> This was my question to Michal in the devel-list...
> But I think it's safe to merge my latest suggestion.
Well, at this point we are already in the global context, no need for
"global ..." .
This should be safe, checking the PHP version is checking the PHP version :)
More information about the Developers