[Phpmyadmin-devel] theme generation & version checking

Marc Delisle Marc.Delisle at cegepsherbrooke.qc.ca
Mon Jul 31 19:35:40 CEST 2006


in 2.7.0-pl2/libraries/select_theme.lib.php we did

if ($theme_generation != PMA_THEME_GENERATION)
     continue; // different generation

if ($theme_version < PMA_THEME_VERSION)
     continue; // too old version

Since 2.8.0 there is no verification against PMA_THEME_GENERATION and 
PMA_THEME_VERSION in PMA_THEME::loadInfo(), why?

Also, I would prefer if we go back for 2.9.0 to this
$theme_version = 2;
$theme_generation = 2;

instead of
$theme_full_version = '2.8';

it would make generation and version comparisons easier in loadInfo().


More information about the Developers mailing list