[Phpmyadmin-devel] Timezone settings

[Sebastian Mendel]

Marc Delisle schrieb:
> Sebastian Mendel a écrit :
>> Marc Delisle schrieb:
>>> Sebastian Mendel a écrit :
>>>> Hi
>>>>
>>>> ---
>>>> Strict Standards: str*time() [function.str*time]: It is not safe to 
>>>> rely on
>>>> the system's timezone settings. Please use the date.timezone setting, 
>>>> the TZ
>>>> environment variable or the date_default_timezone_set() function.
>>>> ---
>>>>
>>>> how should we handle this?
>>>>
>>>> by default the date.timezone should be setup in the php.ini
>>>>
>>>> so we should check this and set it if not set - but what value?
>>>>
>>>> adding one more main.php option to display and setup timezone?
>>> Maybe we could do this:
>>>
>>> - temporarily disable E_STRICT like we did in 2.11
>>> - date_default_timezone_set( date_default_timezone_get() );
>>> - reenable E_STRICT (if it was active)
>>
>> 'disabling' is not the way i would suggest
>>
>> phpMyAdmin should just ensure display_errors is disabled - and not alter 
>> error_level()
>>
>> completely hiding errors was/should only a temporaly solution for cross 
>> PHP 4 and 5 version <= 2.11 ...
>>
>> the admin should see, that he should set default time zone!
>>
>> the admin should see all errors he want, without the need changing the code
> 
> We are not sure who is seeing this message, an admin or a simple user. 
> But assuming that an admin would at least display the main PMA page, we 
> could add a test there that ensures he sees the error!

if we disable display_error the 'simple user' cannot see any errors, but the 
admin can see them, cause error_reporting is still on, or at least to the 
value the admin selected in php.ini


> Otherwise I don't follow your logic. You want to handle this message or 
> not? :)

hide from 'simple user' with display_error off and show to admin (in the PHP 
error log) with error_reporting on (E_ALL) or better not touch 
error_reporting - the admin should know what he is doing - but only ensure 
the 'simple user' does not see PHP errors by disabling display_error

short:

  - do not touch error_reporting - the admin should now what he does
    error_reporting does not cause any harm!

  - ensure display_errors is off - in case the admin does not know ...
    display_errors can provide essential system information to a bad user

-- 
Sebastian