[Phpmyadmin-devel] trunk: can't login

[Marc Delisle]

Marc Delisle a écrit :
> Sebastian Mendel a écrit :
>> Sebastian Mendel schrieb:
>>> Marc Delisle schrieb:
>>>> Hi,
>>>> with current trunk, all cookies deleted, browser closed (and reopened :) 
>>>> ), cannot login.
>>> my fault ... working on it ...
>>>
>>>
>>> this cookie auth code is ... strange ...
>>
>> ok, should work again
>>
>>
> 
> - The undefined last_access_time message is back
> 
> - I can login (yeah!)
> 
> - I choose a db in the navi frame
> 	-> sometimes I'm back to login panel
> 	-> sometimes I lose the navi frame
> 
> Marc

Fixed now, thanks. There is a small issue, I think we should apply this:

Index: cookie.auth.lib.php
===================================================================
--- cookie.auth.lib.php (revision 10121)
+++ cookie.auth.lib.php (working copy)
@@ -390,7 +390,7 @@

      // User inactive too long
      if ($_SESSION['last_access_time'] < time() - 
$GLOBALS['cfg']['LoginCookieValidity']) {
-        if ($_SESSION['last_access_time'] < time() - 
$GLOBALS['cfg']['LoginCookieValidity'] * 4) {
+        if ($_SESSION['last_access_time'] < time() - 
$GLOBALS['cfg']['LoginCookieValidity'] ) {
              $GLOBALS['no_activity'] = true;
              PMA_auth_fails();
              exit;

because, the * 4 was there to avoid display the "No Activity" message 
when much time has passed (like next morning) however, currently, the 
message does not show up in some cases, for example, try
$cfg['LoginCookieValidity']     = 20;