[Phpmyadmin-devel] any odds against splitting common.lib.php into .lib.php and .inc.php?

[Sebastian Mendel]

Michal Čihař schrieb:
> Hi
> 
> On Tue, 20 Mar 2007 13:24:54 +0100
> Sebastian Mendel <lists at sebastianmendel.de> wrote:
> 
>> i would also drop the
>>
>> if (!defined('PMA_MINIMUM_COMMON')) {
>>
>> arround the functions, as i cannot think and do not detect any speed
>> improvements upon this
>>
>> the only thing where this would help if this 'not so' common function would
>> be in another sperate file what is include
>> if (!defined('PMA_MINIMUM_COMMON'))
>>
>> common.inc.php:
>>
>> require_once 'core.lib.php';
>> if (! defined('PMA_MINIMUM_COMMON')) {
>>     require_once 'common.lib.php'
>> }
> 
> Okay for me.

so you think split on core and common, or just remove if
(!defined('PMA_MINIMUM_COMMON'))?


(just talking about the functions, not the procedural code)

-- 
Sebastian Mendel

www.sebastianmendel.de