[Phpmyadmin-devel] themes compatibility with 2.11

[Marc Delisle]

Marc Delisle a écrit :
> Hi,
> 
> For 2.11 there has been a change: phpmyadmin.css and print.css are now 
> in the main directory.
> 
> To accomodate this, a change has been made in svn trunk for all themes:
> 
> -    background-image:   url(../<?php echo 
> $_SESSION['PMA_Theme']->getImgPath(); ?>s_warn.png);
> +    background-image:   url(<?php echo 
> $_SESSION['PMA_Theme']->getImgPath(); ?>s_warn.png);
> 
> I would prefer if the themes in trunk can work with 2.11 and also prior 
> versions, so I suggest we do something like this:
> 
>   background-image: url(<?php echo 
> version_compare(PMA_VERSION,'2.11','lt') ? '../' : ''; echo 
> $_SESSION['PMA_Theme']->getImgPath(); ?>s_warn.png);
> 
> Too bad we did not think earlier to define a PMA_INT_VERSION.
> 
> Marc

After discussing with Sebastian, finally we'll have a copy of themes in 
branches/QA_2_10/themes; those themes will be 2.10.x-compatible, and 
those in trunk will be compatible with the current dev version.

So, no version_compare() needed.

I'll try to create this branch today.

Marc