[Phpmyadmin-devel] relation.lib.php PMA_getComments()

[Marc Delisle]

Sebastian Mendel a écrit :
> Hi,
> 
> marc, in PMA_getComments() you iterate over the result from
> 
> SELECT `comment`
> FROM ' . PMA_backquote($cfgRelation['db']) . '.' .
> PMA_backquote($cfgRelation['column_info']) . '
> WHERE db_name     = \'' . PMA_sqlAddslashes($db) . '\'
> AND table_name  = \'\'
> AND column_name = \'(db_comment)\'';

Sebastian,
no, the code iterates over the results contained in $com_rs which has 2 
possible sources: the query you mention and another one that can have 
many rows because it retrieves all the column comments for one table.

> 
> 
> i did not get the point, cause this will always return only one row
> 
> i think you just missed to correctly refactor the whole code for this function
> 
> revision 6758
>