[Phpmyadmin-devel] relation.lib.php PMA_getComments()

[Marc Delisle]

Sebastian Mendel a écrit :
> Marc Delisle schrieb:
>> Sebastian Mendel a écrit :
>>> Hi,
>>>
>>> marc, in PMA_getComments() you iterate over the result from
>>>
>>> SELECT `comment`
>>> FROM ' . PMA_backquote($cfgRelation['db']) . '.' .
>>> PMA_backquote($cfgRelation['column_info']) . '
>>> WHERE db_name     = \'' . PMA_sqlAddslashes($db) . '\'
>>> AND table_name  = \'\'
>>> AND column_name = \'(db_comment)\'';
>> Sebastian,
>> no, the code iterates over the results contained in $com_rs which has 2 
>> possible sources: the query you mention and another one that can have 
>> many rows because it retrieves all the column comments for one table.
> 
> oh, yes, of course, i was ... confused ... by my own changes ... ;-)
> 
> but now we can drop the part where we get column comments from PMA db?
> 

I think so. But this means that if a user upgrades from a MySQL version 
that did not support column comments, he has to use PMA 2.11 so that the 
column comments are migrated to native comments.

This brings to another question: should we drop the pmadb-based column 
comments feature in PMA 3?

Marc