[Phpmyadmin-devel] trunk and $GLOBALS['charset_connection']

Sebastian Mendel lists at sebastianmendel.de
Mon Jan 21 10:57:40 CET 2008


Sebastian Mendel schrieb:
> Marc Delisle schrieb:
>> Hi,
>> in this revision:
>> http://phpmyadmin.svn.sourceforge.net/viewvc/phpmyadmin/trunk/phpMyAdmin/libraries/database_interface.lib.php?r1=10984&r2=10990
>>
>> the code that sets $GLOBALS['charset_connection'] was removed. However 
>> this variable is still used.
> 
> i see, my fault
> 
> IMHO this occurrences can just be removed, their is no need for CONVERT(), 
> this should all be done with SET NAMES by MySQL itself
> 
> any conclusions?

at least i have no working testcase where i get different results whether i 
use CONVERT() or not

-- 
Sebastian




More information about the Developers mailing list