[Phpmyadmin-devel] permanent storage feature done - please provide your feedback

[Sebastian Mendel]

On 13.08.2009 07:21, Zeeshan M. wrote:
>  >you should try to replace this .... with a single function call, e.
> g.: $GLOBALS['cfg']['PropertiesNumColumns'] =
> PMA_permUsrPrefGet('PropertiesNumColumns');
>
> This would help put the code in one central location.  This is probably
> better than having the code scattered all over.

yes

> But I don't think it
> would help reduce the amount of code being written, if it were one of
> the goals.  Some of the settings are not directly applied to global
> config vars so they have to go through conditional statements.

btw. why do you not just apply all user settings at once?

i am not familiar with the detailed current handling of configuration in 
the session, but IMHO this should only be required once per session

even if this is not an option, in most cases you set only one user 
option and this could be done with a single function call




i would suggest include the user pref class in common.inc.php and apply 
all user settings at once, additionally i would move all related code 
into the class (except the initial call of course)

Michal, what do you think?


-- 
Sebastian Mendel