[Phpmyadmin-devel] Patch for 'ID: 1494550'

[Michal Čihař]

Hi

Dne Wed, 7 Apr 2010 18:26:46 +0530
Kishanthan Thangarajah <kshanth2101 at gmail.com> napsal(a):

> I have created a patch for
> <http://sourceforge.net/tracker/index.php?func=detail&aid=1494550&group_id=23067&atid=377411>
> it is a Javascript popup for entering values and create text field
> content according to the entered value.
> I welcome all your feedback on this.

It's better to use patch tracker for patch submissions.

However few comments:

1. There is no way to stop the beast, it asks again and again.
2. It does not honor original value.
3. Do you really think that opening dozens of dialogs is less painful
   than editing single text field.
4. It does not add values, it just replaces them.

-- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20100407/98c127cb/attachment.sig>