[Phpmyadmin-devel] Inconsistent format strings

[Marc Delisle]

Michal Čihař a écrit :
> Hi
> 
> for several times I wondered why we use so many different ways to
> create format strings, let's take three examples:
> 
> 
> $cfg['DefaultQueryTable'] = 'SELECT * FROM %t WHERE 1';
> 
> where
>  * %d will be replaced by the database name.
>  * %t will be replaced by the table name.
>  * %f will be replaced by a list of field names.
> 
> 
> 
> $cfg['Export']['file_template_table'] = '__TABLE__';
> 
> where __TABLE__, __DB__ and __SERVER__ are used
> 
> 
> 
> $cfg['TitleTable'] = '@HTTP_HOST@ / @VSERVER@ / @DATABASE@ / @TABLE@ | 
> @PHPMYADMIN@';
> 
> where @HTTP_HOST@, @SERVER@, @VERBOSE@, @VSERVER@, @DATABASE@, @TABLE@
> and @PHPMYADMIN@ can be used
>
> How about making use just single way to do this and create common
> function which will do the formatting?

And how about dropping these features? Sometimes when I look at the code
I see configurable things that I never felt the need to change. But
maybe I'm too radical in suggesting to drop them :)


-- 
Marc Delisle
http://infomarc.info