[Phpmyadmin-devel] Themes: Artic Ocean and Smooth Yellow

[Michael Keck]

Hi Marc,
Hi List,

I've updated the theme Artic Ocean for PMA 3.x
https://sourceforge.net/tracker/?func=detail&aid=2964505&group_id=23067&atid=689412

and replaced XAMPP (Apachefriends) Theme with Smooth Yellow
https://sourceforge.net/tracker/?func=detail&aid=2964529&group_id=23067&atid=689412


> Am 05.03.2010 11:17, schrieb Michal Čihař:
>
> On demo server, lot (maybe all) of themes throw out errors:
>
> Call to a member function get() on a non-object in
> themes/aqua/css/theme_left.css.php on line 19#012
> Call to a member function get() on a non-object in
> themes/aqua/css/theme_right.css.php on line 19#012
> Call to a member function get() on a non-object in
> themes/aqua_brushed/css/theme_left.css.php on line 19#012
> Call to a member function get() on a non-object in
> themes/aqua_brushed/css/theme_right.css.php on line 19#012
> Call to a member function get() on a non-object in
> themes/arctic_ocean/css/theme_left.css.php on line 26#012
> Call to a member function get() on a non-object in
> themes/arctic_ocean/css/theme_right.css.php on line 29#012
> Call to a member function get() on a non-object in
> themes/clearview3/css/theme_right.css.php on line 19#012
> Call to a member function get() on a non-object in
> themes/clearview3/css/theme_left.css.php on line 17#012
>
> Do somebody have an idea how to fix it? 

> Am 06.03.2010 17:59, schrieb Marc Delisle:
>
> There is at least one difference that I remember: the configuration was
> moved from session to globals.

That was the problem. Now I've fixed it with this hack:

if (isset($GLOBALS['PMA_Config']) && $GLOBALS['PMA_Config']->get('fontsize') !== null) {
    $pma_fsize = $GLOBALS['PMA_Config']->get('fontsize');
} else if (isset($_SESSION['PMA_Config']) && $_SESSION['PMA_Config']->get('fontsize')) {
    $pma_fsize = $_SESSION['PMA_Config']->get('fontsize');
} else {
    if (isset($_COOKIE['pma_fontsize'])) {
        $pma_fsize = $_COOKIE['pma_fontsize'];
    }
}
$pma_fsize = preg_replace("/[^0-9]/", "", $pma_fsize);
if (!empty($pma_fsize)) {
    $pma_fsize = ($pma_fsize * 0.01);
} else {
    $pma_fsize = 1;
}

This can be a solution on many themes at the moment.
But - why do we have so many different things to store PMA_Configs?

Regards
Michael


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 291 bytes
Desc: OpenPGP digital signature
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20100307/5ac34b1f/attachment.sig>