[Phpmyadmin-devel] sql export : functions/routines

[Dieter Adriaenssens]

2010/9/19 Marc Delisle <marc at infomarc.info>:
> Dieter Adriaenssens a écrit :
>> 2010/9/19 Marc Delisle <marc at infomarc.info>:
>>> Dieter Adriaenssens a écrit :
>>>> Hi,
>>>>
>>>> 2010/9/11 Marc Delisle <marc at infomarc.info>:
>>>>> P.S. I just made a test with current master and with either Quick or
>>>>> Custom methods, functions, procedures and events are missing from the
>>>>> export.
>>>> I guess they should be exported. ;)
>>> Fixed in commit 598d3b898d.
>>
>> I just prepared an identical fix, but couldn't push it because there
>> were changes in master. ;)
>>
>
> Hi Dieter,
> do you have merge conflicts? Normally you just have to pull from master
> then push to it.

Hi Marc,

No conflicts. I did a pull, looked into functions/procedures/events
not exporting in master, fixed it, committed (locally) and pushed it.
But it gave an error, because in the mean time, you had pushed two
commits, one of them fixing the same problem. So we just fixed the
same bug more or less on the same moment, but you were quicker in
submitting it to the repository. ;)
Maybe I should have done a pull before doing the push. Is it good practice?

BTW : I removed my local commit.

Greets,

Dieter

>
> --
> Marc Delisle
> http://infomarc.info
>
> ------------------------------------------------------------------------------
> Start uncovering the many advantages of virtual appliances
> and start using them to simplify application deployment and
> accelerate your shift to cloud computing.
> http://p.sf.net/sfu/novell-sfdev2dev
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>



-- 
Groetjes,

Dieter Adriaenssens