[Phpmyadmin-devel] New navigation frame resize handler

[Rouslan Placella]

On Mon, 2011-08-08 at 14:17 +0300, Tyron Madlener wrote:
> On Mon, Aug 1, 2011 at 3:54 PM, Rouslan Placella <rouslan at placella.com> wrote:
> > On Mon, 2011-08-01 at 15:39 +0300, Tyron Madlener wrote:
> >> On Mon, Aug 1, 2011 at 3:31 PM, Rouslan Placella <rouslan at placella.com> wrote:
> >> > On Mon, 2011-08-01 at 14:24 +0200, Herman van Rink wrote:
> >> >> On 08/01/2011 01:34 AM, Rouslan Placella wrote:
> >> >> > I rewrote the navigation frame resize handler and I'm looking for some
> >> >> > feedback and opinions. The new handler keeps navigation frame width
> >> >> > synchronised and there is an option to collapse the frame. I made a
> >> >> > video [1] that showcases the functionality and there are a few words
> >> >> > about it in my blog [2] and of course, it can be seen ion action on my
> >> >> > demo site [3].
> >> >>
> >> >> Having it resizeable seems nice. But I'm not sure that the
> >> >> synchronisation between tabs is useful.
> >> >> When I would resize to fit some specific table names this does not mean
> >> >> that I need the same space for an other tab where I might have a
> >> >> different database.
> >> > I was thinking of adding a configuration option to disable this.
> >>
> >> I agree with Herman, this feature seems rather like an inconvenience
> >> than a feature to me. And this would be the very first
> >> setting/configuration in phpMyAdmin that is synchronized - why does it
> >> deserve that status? ;)
> >
> > Not sure what you are saying here... What status is there to deserve?
> >
> > Anyway, I meant a configuration setting for disabling this feature, not
> > synchronising the actual setting. And the synchronisation of the frame
> > widths occurs via a cookie, not via the pma configuration...
> >
> > But yeah, I see how you could label it a nuissance and I have no problem
> > getting rid of the feature for synchronising widths across frames and
> > reverting to the old, somewhat flawed, logic for handling the frame
> > widths.
> 
> How about just adding your new code without cross frame sync?

Yeah, that's what I thought as well, so I already I reverted the cross
frame sync in my branch. The development of rest of new navigation is
going kinda slow, so I don't expect to merge with master any time soon.

> >
> >> >> And I'm not really a fan of polling, specially when it's just for this.
> >> > Well, some browsers don't fire the onresize event for frames. Polling is
> >> > the only reliable way here.
> >