[Phpmyadmin-devel] legal concerns about external libraries

[Dieter Adriaenssens]

2011/8/10 Marc Delisle <marc at infomarc.info>:
> Le 2011-08-10 03:32, Dieter Adriaenssens a écrit :
>> 2011/8/8 Marc Delisle <marc at infomarc.info>:
>>> Marc Delisle a écrit :
>>>> Michal Čihař a écrit :
>>>>> Hi
>>>>>
>>>>> Dne Wed, 03 Aug 2011 07:45:53 -0400
>>>>> Marc Delisle <marc at infomarc.info> napsal(a):
>>>>>
>>>>>> in this old message from June 2004
>>>>>> https://sourceforge.net/mailarchive/forum.php?thread_name=20040608142911.GA10581%40ns.liten.cz&forum_name=phpmyadmin-devel
>>>>>> you mention that you added MS Excel export with PEAR
>>>>>> Spreadsheet_Excel_Writer.
>>>>> Yes, it was completely different code compared to current one and it did
>>>>> require setup from user (it required temporary dir to construct files).
>>>>>
>>>>>> Then Garvin Hicking replied "it's a good benefit".
>>>>>>
>>>>>> We could ask the phpmyadmin-users list about use cases.
>>>>> For whatever feature, you will always find at least one user :-).
>>>>
>>>> True but for a feature that has been in the code since 2004, the base of
>>>>   persons using it has had the time to grow. Especially when we're
>>>> talking about a product as popular as MS Excel.
>>>>
>>>
>>> Well, a few days after asking on the phpmyadmin-users list about this,
>>> we got four answers and they are happy with using CSV for their export
>>> and import needs.
>>
>> I find it strange there are no objections against removing support for
>> import/export excel files from our user base, but if nobody really
>> needs it, then we can remove it I guess.
>
> As Michal said, "for whatever feature, you will always find at least one
> user" so at this point, I'm not saying that nobody needs it. However,
> these users should find that CSV import/export is a correct replacement
> for this feature.
>
>>
>>> Removing PHPExcel for the upcoming 3.5 is something we could easily do,
>>> and we could also remove it for the 3.4.5 release (or 3.4.4-rc2) so that
>>> the Fedora team can see the licensing issue resolved for our current
>>> stable release.
>>
>> I'll remove PHPExcel and the import/export for Excel from QA_3_4, or
>> shall I create a branch first, to test it?
>
> I don't think a branch is necessary. Please do the removal.

library/PHPExcel and native Excel import/export was removed from
QA_3_4 (ready for 3.4.5) and master.
I've run into some things that seemed to be used only by Excel
export/import, but haven't removed them yet :

- config option TempDir -> according to Documentation.html this was
needed for Excel export, the option is only used in File.Class.php ->
checkUploadedFile()
- checkUploadedFile () -> not used anymore
- PMA_getColumnNumberFromName() -> not used

Shall I remove them as well, or will they be needed in the future?

BTW : PMA_getColumnAlphaName() is still used by ods import

>>
>>> Still have to verify the tcpdf issue, however.
>>>
>>>
>>> --
>>> Marc Delisle
>>> http://infomarc.info
>>>
>>> ------------------------------------------------------------------------------
>>> BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA
>>> The must-attend event for mobile developers. Connect with experts.
>>> Get tools for creating Super Apps. See the latest technologies.
>>> Sessions, hands-on labs, demos & much more. Register early & save!
>>> http://p.sf.net/sfu/rim-blackberry-1
>>> _______________________________________________
>>> Phpmyadmin-devel mailing list
>>> Phpmyadmin-devel at lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>
>>
>>
>>
>
>
> --
> Marc Delisle
> http://infomarc.info
>
> ------------------------------------------------------------------------------
> uberSVN's rich system and user administration capabilities and model
> configuration take the hassle out of deploying and managing Subversion and
> the tools developers use with it. Learn more about uberSVN and get a free
> download at:  http://p.sf.net/sfu/wandisco-dev2dev
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>



-- 
Groetjes,

Dieter Adriaenssens