[Phpmyadmin-devel] column reorder potential problem

[Aris Feryanto]

On 12 Agu 2011, at 20:33, Marc Delisle <marc at infomarc.info> wrote:

> Le 2011-08-11 22:18, Aris Feryanto a écrit :
>> 
>> On 12 Agu 2011, at 03:28, Marc Delisle <marc at infomarc.info> wrote:
>> 
>>> Aris Feryanto a écrit :
>>>> Hi Marc,
>>>> 
>>>>> From: Marc Delisle <marc at infomarc.info>
>>>> 
>>>>> Aris Feryanto a écrit :
>>>>>> Hi,
>>>>>> 
>>>>>>> From: Aris Feryanto <aris_feryanto at yahoo.com>
>>>>>>> Hi Marc,
>>>>>>> 
>>>>>>>>  From: Marc Delisle <marc at infomarc.info>
>>>>>>>>  Aris,
>>>>>>>> 
>>>>>>>>  please have a look at [0]. It's interesting to see your code 
>>>>> being
>>>>>>>>  tested by many users at such an earlier stage.
>>>>>>>> 
>>>>>>>>  [0]
>>>>>>>> 
>>>>> https://sourceforge.net/tracker/?func=detail&atid=377408&aid=3386436&group_id=23067
>>>>>>> Thanks for noticing this. I just looked at the bug report:
>>>>>>> 
>>>>>>> Details: The column reorder-patch breaks or complicates the selection 
>>>>> the text 
>>>>>>> of a column in FF5, especially for (smaller) id columns.
>>>>>>> 
>>>>>>> 
>>>>>>> In my test, I cannot reproduce this after reordering some columns. The 
>>>>> bug only 
>>>>>>> happen after shift+click to select some rows in a table. This is a 
>>>>> known 
>>>>>>> disadvantage of enabling shift+click (I've stated this in when we 
>>>>> were 
>>>>>>> discussing to enable shift+click feature). Should we change it?
>>>>>>> 
>>>>>>> Another way to keep the shift+click feature and text-selection work 
>>>>> together: 
>>>>>>> use javascript to clear selection after shift+click, but it makes the 
>>>>> screen 
>>>>>>> flickering for a while. You may try this in "clear_selection" 
>>>>> branch 
>>>>>>> in my git.
>>>>>>> 
>>>>>> Any comment on the text selection problem?
>>>>> Aris,
>>>>> I cannot reproduce this problem. By the way, I believe that what Sven 
>>>>> Strickroth means is not that to reproduce the problem, you have to 
>>>>> reorder the columns. He means that since this patch has been merged, he 
>>>>> has this problem.
>>>>> 
>>>>> You might want to clarify this with him, in the bug tracker.
>>>> 
>>>> Yes, you are right. I just want to know exactly if he had the same issue like the one that I found.
>>>> 
>>>> Here is my scenario to reproduce the text selection problem:
>>>> - browse a table
>>>> - make a selection in some text inside the table interface and notice that the text can be selected
>>> 
>>> I tried with current master.
>>> 
>>> Do you mean selecting some text which is part of the data rows?
>> 
>> Yes, correct. Do you get the same problem?
> 
> No; however since the grid editing feature is there, when I want to
> select text inside a data cell, the text is not selected but when I
> release the mouse button, the grid editing box opens. In this box I can
> select the text, whether or not a checkbox is clicked.

Oh, right. That is the case when we only select text in one cell. What I've tried before was selecting text more than one cell in a row.

Should we handle such selection (e.g., using proposed method in "clear_selection" branch in my git)? Or clarify that such text selection cannot be done in order to enable the shift+click feature (i.e., user must select the cells one by one)?

> 
>> 
>>> 
>>>> - click on one of the checkboxes in the table rows
>>>> - now, try to make a text selection again and notice that the text cannot be selected anymore
>>>> 
>>>>> Also, ask him if he has FF extensions other than Firebug, and what is 
>>>>> his workstation platform.
>>>>> 
>>>> 

--
Aris Feryanto
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20110813/c2113e13/attachment.html>