[Phpmyadmin-devel] "Monitor" broken in master

[Tyron Madlener]

On Sat, Aug 20, 2011 at 8:47 PM, Tyron Madlener <tyronx at gmail.com> wrote:
> On Sat, Aug 20, 2011 at 8:45 PM, Tyron Madlener <tyronx at gmail.com> wrote:
>> On Sat, Aug 20, 2011 at 6:34 PM, Rouslan Placella <rouslan at placella.com> wrote:
>>> Tyron,
>>>
>>> The monitor in current master is now broken. New datapoints are not
>>> plotted correctly anymore. Screenshot attached. I think this happened
>>> some time yesterday and may have to do with those optimisations that
>>> Piotr pushed, though I'm not sure.
>>>
>>> Rouslan
>>
>> This is really odd because the error doesn't seem to be caused by any
>> change in the related files functions.js, server_status.php,
>> server_status.js or server_status_monitor.js
>>
>> On my fork (http://demo.phpmyadmin.net/gsoc-tyron) the charts still
>> work. And replacing any of above files on the master version did not
>> have any effect.
>>
>
> The json data still is transferred and added to each chart correctly.
> But the highchart charts doesn't recognize the millisecond-timestamp
> as a correct time anymore.
>

Oh ok found the error. Michal encapsed all the js variables in
strings, thus breaking the server time calculation.

>>>
>>> ------------------------------------------------------------------------------
>>> Get a FREE DOWNLOAD! and learn more about uberSVN rich system,
>>> user administration capabilities and model configuration. Take
>>> the hassle out of deploying and managing Subversion and the
>>> tools developers use with it. http://p.sf.net/sfu/wandisco-d2d-2
>>> _______________________________________________
>>> Phpmyadmin-devel mailing list
>>> Phpmyadmin-devel at lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>
>>>
>>
>