[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Structure ->Column->Change

Marc Delisle marc at infomarc.info
Mon Jul 11 20:43:44 CEST 2011


Le 2011-07-11 13:32, Thilanka Kaushalya a écrit :
> Hi Marc,
>
>     Yes it's ok to move this section, to avoid code duplication.
>     functions.js is cached in the browser so the downside of increased size
>     is minimal.
>
>
> I did the changes and pushed to the repo. Please check that. Thank you.
>
> Regards,
> Thilanka.

Works fine but commit 215eb80df9b5456d4b2131bb98d8448797ef2c74 needs an 
improvement; please avoid this kind of syntax:

$($temp_div)

It should be just
$temp_div

as this is already a jQuery object.


-- 
Marc Delisle
http://infomarc.info




More information about the Developers mailing list