[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Structure ->Column->Change

Thilanka Kaushalya lgtkaushalya at gmail.com
Thu Jul 21 04:28:28 CEST 2011


Hi Rouslan,

Looks good to me, for whatever that's worth. The only things that I

> noticed that you might want to have a look at are:
>
>  * Since PMA_convertFootnotesToTooltips() now takes a parameter,
>   you might want to add a PHPDOC header to it to explain what
>   that parameter is for and that it can be omitted.
>

Thank and now I added them.

 * The 'span_id' variable in PMA_convertFootnotesToTooltips() is
>   now misleading, since it stores a class, not an id.
>
>
In here even though it initially search for classes, the results are taken
as ids for spans. That's why I kept it in that manner.

Thank you.

Regards,
Thilanka.


-- 
L G Thilanka Kaushalya
Computer Science & Engineering,
University of Moratuwa,
Sri Lanka

Connect with me at,
      Gmail        : lgtkaushalya at gmail.com
      Twitter       : @thilanka_k
      Facebook  : Thilanka Kaushalya
      Yahoo       : lgtkaushalya at yahoo.com
      Blog          : http://coders-view.blogspot.com/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20110721/305e272c/attachment.html>


More information about the Developers mailing list