[Phpmyadmin-devel] initTooltips rename

Tyron Madlener tyronx at gmail.com
Thu Jul 21 19:19:02 CEST 2011


On Thu, Jul 21, 2011 at 8:18 PM, Marc Delisle <marc at infomarc.info> wrote:
> Le 2011-07-21 13:03, Tyron Madlener a écrit :
>> On Thu, Jul 21, 2011 at 6:18 PM, Marc Delisle<marc at infomarc.info>  wrote:
>>> Le 2011-07-21 11:01, Marc Delisle a écrit :
>>>>>>
>>>>>> P.S. I suggest renaming initToolTips() to a better name like
>>>>>> PMA_convertFootnotesToTooltips().
>>>>>
>>>>> initToolTips() was used on the status page, so that broke the status
>>>>> page on the master demo for now. I have already patched it in my repo.
>>>>
>>>> Sorry, I had thought about it but afterwards forgot. I'll cherry-pick
>>>> your patch and apply it to origin/master.
>>>>
>>>>
>>> Tyron,
>>> The cherry-pick failed with conflicts between your tree and the origin.
>>> The file js/server_status.js has different modifications.
>>
>> Yea I thought so. We can wait until next time Michal merges my repo.
>> That or just replace initTooltips with PMA_convertFootnotesToTooltips.
>
> Done.

Thanks :-)

>
>> It only appears a single time in server_status.js at the beginning
>> somewhere.
>> I can merge back with master afterwards to avoid merge conflicts.
>
>
>
> --
> Marc Delisle
> http://infomarc.info
>
> ------------------------------------------------------------------------------
> 5 Ways to Improve & Secure Unified Communications
> Unified Communications promises greater efficiencies for business. UC can
> improve internal communications as well as offer faster, more efficient ways
> to interact with customers and streamline customer service. Learn more!
> http://www.accelacomm.com/jaw/sfnl/114/51426253/
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>




More information about the Developers mailing list