[Phpmyadmin-devel] PMA Icon Spritify

[Rouslan Placella]

On Thu, 2011-07-21 at 15:45 +0200, Michal Čihař wrote:
> Hi
> 
> Dne Thu, 21 Jul 2011 15:05:26 +0300
> Tyron Madlener <tyronx at gmail.com> napsal(a):
> 
> > On Thu, Jul 21, 2011 at 2:48 PM, Michal Čihař <michal at cihar.com> wrote:
> > > Hi Tyron
> > >
> > > Any answers to questions bellow?
> > 
> > I actually wrote 2 days ago but yet again, I've replied to you
> > personally instead of replying to the mailing list >.<
> 
> I probably missed that one, sorry.
> 
> > > Dne Tue, 19 Jul 2011 14:04:20 +0200
> > > Michal Čihař <michal at cihar.com> napsal(a):
> > >
> > >> Dne Fri, 15 Jul 2011 10:41:32 +0300
> > >> Tyron Madlener <tyronx at gmail.com> napsal(a):
> > >>
> > >> > Hi, I've got a huge patch ready. In my branch 'sprites' I have
> > >> > replaced the majority of all pma icons with sprites. This gives us the
> > >> > following advantages
> > >>
> > >> How does it affect browser compatibility?
> > 
> > Shouldn't be any problem. Many major websites use it, like the Google main page.
> 
> Okay, sounds good.
> 
> > >> - Sprites and CSS were automatically generated using
> > >> http://spritegen.website-performance.org/ - this can be used to update
> > >> the sprite data at a later point
> > >
> > > But you've deleted the original images from the git repo, I think they
> > > should be kept for possible later updates.
> > 
> > Yes, that's why I have re-added them in a later commit :-)
> > 
> > > Also process of regenerating
> > > sprites should be documented.
> > >
> > 
> > Yea, the way I did it for the original theme now is take the
> > sprites-block from theme_right.css.php, applied a bunch of regexps
> > from my favorite editor to turn 'ic_sdf { ... }'
> > into 'sdf.png', regexp'd it further to a php array and with 3 lines of
> > php code copied all these image files to a new folder.
> 
> Please can you write wiki page with step by step instructions? I can
> make script to automate that later.
> 
> Otherwise I think it is okay, I'm going to merge it in few minutes.

Just noticed that the + and - icons that are used in the navigation
frame when $cfg['LeftFrameLight']=false are broken. Instead, an arrow
pointing down is now shown for both. I think that the JS code that
handles changing these icons is written specifically for images, not
sprites, and needs to be looked at.

Rouslan