[Phpmyadmin-devel] CheckStyle violations in export files

Madhura Jayaratne madhura.cj at gmail.com
Fri Jul 22 19:04:55 CEST 2011


Hi all,

Looking at the CheckStyle reports from the CI, all the export files show
very high counts of indentation rule violations.
The code in the 'else' block of 'if (isset($plugin_list))' condition is
wrongly indented in all of these files.

There are two possible ways to correct this.
1) Correctly indent the 'else' block
2) Add 'return' statement to the end of 'if' block and remove 'else {' part.

Which one if preferred?

-- 
Thanks and Regards,

Madhura Jayaratne
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20110722/1f4d033a/attachment.html>


More information about the Developers mailing list