[Phpmyadmin-devel] Collapsible navigation frame

[Tyron Madlener]

On Thu, Jul 28, 2011 at 12:29 AM, Rouslan Placella <rouslan at placella.com> wrote:
> On Wed, 2011-07-27 at 22:20 +0300, Tyron Madlener wrote:
>> On Wed, Jul 27, 2011 at 10:08 PM, Marc Delisle <marc at infomarc.info> wrote:
>> > Tyron Madlener a écrit :
>> >> On Wed, Jul 27, 2011 at 7:51 PM, Marc Delisle <marc at infomarc.info> wrote:
>> >>> Tyron Madlener a écrit :
>> >>>> Just had a good idea how to fix the 'open in new tab' workaround for
>> >>>> getting more space on various pages (particularly useful on the status
>> >>>> monitor). I've implemented a very quick demonstration on how a
>> >>>> collapsible navigation frame could work like. If the idea is good and
>> >>>> the feature can go to master, I will implemented it better. Also it
>> >>>> could need a better icon.
>> >>>>
>> >>>> Commit 5fb7f9cd1716ae747a6e898ee6e92c864d4da6dc and
>> >>>> 05dd085aeb0334d1e9ee68037efb563866892164 do the magic. It will make an
>> >>>> arrow appear vertically centered on the nav frame.
>> >>>> Should be testable anytime soon on http://demo.phpmyadmin.net/gsoc-tyron
>> >>> Tyron,
>> >>> Taking into account that phpMyAdmin currently has the navi panel inside
>> >>> a frame, what's the advantage (apart from the look) of this, compared to
>> >>> just dragging the vertical separator line?
>> >>>
>> >>
>> >> That it is significantly less convenient to find that 3 pixel wide
>> >> area where you can drag the frame, then move it to the end of the
>> >> screen. Also it doesn't seem to be possible in Chrome. Also there's no
>> >> visual indicator showing this is possible, so the average user might
>> >> never be aware of it.
>> >
>> > I see your point. By the way, a few hours ago I was able to make it work
>> > on my copy of your tree but it no longer works (nor on the demo server).
>> >
>>
>> That is odd, it is still working for me on the gsoc-tyron demo, maybe
>> because i used static theme paths (for testing)?
>>
>> >>
>> >> I have to mention though, my current code doesn't seem to work in
>> >> Opera. But I guess that is only a matter of some bug fixing.
>
> I'm working on a big re-structuring of the navigation frame. The impact
> on the user will probably be nearly none, however the underlying code
> will probably be unrecognisable since I'm going for an OOP model. So, if
> your feature is to go into master and also mine, I suspect that one of
> us will have to do a difficult merge. And since your feature is smaller,
> I wonder if you want to wait until I'm finished and then implement yours
> on top of the new navigation code. What do you think?
>
> Rouslan
>

Sure, my feature was just a few code line changes. I'll revert it
before Michal merges my repo next time.

>
> ------------------------------------------------------------------------------
> Got Input?   Slashdot Needs You.
> Take our quick survey online.  Come on, we don't ask for help often.
> Plus, you'll get a chance to win $100 to spend on ThinkGeek.
> http://p.sf.net/sfu/slashdot-survey
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>