[Phpmyadmin-devel] Grid editing

[Marc Delisle]

Le 2011-07-29 11:11, Aris Feryanto a écrit :
> ----- Original Message -----
> 
>> From: Marc Delisle <marc at infomarc.info>

>> Other remarks:
>> 
>> 1. After saving all at once, there is an empty div with class
>> notice about the displayed UPDATE statement.
> 
> Fixed.
> 
>> 
>> 2. I wonder about the best place to display the "Save edited data"
>>  button. Maybe on the data row (next to the other actions link)?
> 
> Is "next to the other actions link" means somewhere near "Edit" or
> "Delete" button?
Yes.

> 
>> 
>> 3. I hope that we'll get the OK from other developers to remove the
>> row inline edit feature, because with the current code,
>> 
>> 3.1 we have two features to do almost the same thing 3.2 currently,
>> clicking on inline edit then on a cell activates the grid editing!
> 
> I hope so. Any objections?
> 
>> 
>> 4. With this feature, we have the same problems as with inline
>> edit, such as:
>> 
>> 4.1 (minor) If there is a sort over one column then this column is
>>  edited for one row, the sorting order is no longer respected
> 
> IMO, this is not a problem, since user can see the updated value
> rather than the value disappear directly to other page.

Good point.
> 
>> 
>> 4.2 (major) For tables with a unique key, if this key is edited,
>> the Edit, Copy and Delete links no longer contain a valid
>> where_clause parameter and the multi-rows actions at the bottom
>> (with selected) no longer work.
>> 
>> 4.3 (major) For tables without a unique key, if any column is
>> edited, the Edit, Copy and Delete links no longer contain a valid
>> where_clause parameter and the multi-rows actions at the bottom
>> (with selected) no longer work.
> 
> 
> Two problems above were fixed.

It's a good progress but the fix is not complete.

About remark 4.2, the Delete link still refers to the old unique key.

About multi-row actions, here is a scenario:
- open sakila.actor
- use the checkbox on two rows
- in the "With selected", click Export
- it works: you are seeing these keys in the generated query

- go back to browsing sakila.actor
- grid edit one row, change the unique key and save
- use the checkbox on two rows, including the one you just grid-edited
- in the "With selected", click Export
- problem: incorrect generated query for the grid-edited row

About remark 4.3, the Edit link still points to the old data and fails,
in the case of a table lacking a unique key.

-- 
Marc Delisle
http://infomarc.info