[Phpmyadmin-devel] Column reordering

[Marc Delisle]

Aris Feryanto a écrit :
> Hi all,
> 
> I pushed my work to git repo in [0]. My recent commits add functionality to remember the column order, so that when we press next, prev, or anything that refresh the table, we will get same column order. The commits also fix some bugs and implement some previous suggestions. If you have some time, you may test the demo at [1]. Any comment or suggestion is really appreciated. :)
> 
> Here is the list of what I did:
> 
> - Remember column order in session or phpMyAdmin configuration storage, if configured.

Aris,
I had a little time to test today. I had a look at how you store the 
column order in pma_table_uiprefs. You are using column numbers. This 
gave me an idea for a possible bug which I tested and proved indeed a bug.

If a structure change occurs in the table (let's say I add a column, 
either after an existing column or at the end), display problems happen.

I also see
Notice in ./libraries/display_tbl.lib.php#461
Undefined index: cf7e1a12c9f636989429f8e2d369eaa5

on a table on which I added a column.

> - Add "Restore table" button to restore table order.

We'll have to find a better name for this button... but it works well. 
Also I'm not sure about showing it greyed when columns are in original 
order.

> - Add compatibility of column reordering with custom "RowActionLinks" (where to show the actions column) and "RepeatCells" (repeat displaying table header every x cells). In current demo, if we set "RepeatCells" to a small number, we can see lines of headers, and we can drag any header to do the reordering.
> - Add different header pointer for vertical display when reordering.
> - Tried to remove the highlighting when we reorder column, but I see that some highlighting (row highlight in horizontal mode) is set from css.
> 
> And I have some bug fix for current official git:
> 
> - Commit 3e3234b156a300e5517d1239755ff49270f24000. Headers not shown correctly in horizontal mode, when we set RowActionLinks = Nowhere, RepeatCells = some value that enough to display repeated header. Header for checkbox is missing.
> - Commit b0717ff8d5aa263b572746711acc50f7996ea87d. "Hide" button (after clicking inline edit) not working correctly when we set RowActionLinks = Right.
> 
> [0] http://repo.or.cz/w/phpmyadmin/arisferyanto.git
> [1] http://demo.phpmyadmin.net/gsoc-aris/
> 
> 
> Regards,
> 
> --
> Aris Feryanto
> 
> ------------------------------------------------------------------------------
> EditLive Enterprise is the world's most technically advanced content
> authoring tool. Experience the power of Track Changes, Inline Image
> Editing and ensure content is compliant with Accessibility Checking.
> http://p.sf.net/sfu/ephox-dev2dev
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel


-- 
Marc Delisle
http://infomarc.info