[Phpmyadmin-devel] GSoC 2011: Support for Routines

[Rouslan Placella]

On Sun, 2011-06-12 at 21:19 +0200, Dieter Adriaenssens wrote:
> 2011/6/12 Rouslan Placella <rouslan at placella.com>:
> > On Sun, 2011-06-05 at 20:23 +0100, Rouslan Placella wrote:
> >> Hi there,
> >>
> >> I've had good progress this week with my work on support for routines
> >> and if you guys have some time I'd be very grateful if you could check
> >> out the currently implemented functionality on my demo server [1] and,
> >> if you have extra time on your hands, also the code in my repo [2].
> >> Currently the "Add", "Edit", "Export" and "Drop" functionalities work
> >> well and are already integrated with AJAX. But the execute functionality
> >> is unfinished and doesn't really work too well yet with or without AJAX
> >> - it's what I'll be working on next week. Any feedback is most welcome!
> >> Thanks.
> 
> Hi Rouslan,
> 
> Looks good. I was able to add, edit, execute, export and drop a routine.
> Few remarks :
> 
> * when adding a routine, it is not added to the list of routines (a
> reload of the page is required)

Odd, it works just fine for me in Chrome/Linux and the routine is added
to the list straight away via JS. I'll have another look at any possible
issues in the code that adds the new entry to the list. But, could you
please double-check that it indeed is not working? Thanks

> * it might be just me, but it's not really clear that there are other
> parameters (like 'Definer', 'Security Type', ...) to consider
> following 'Definition', because they are not visible until you scroll
> down. Is there a way of making the scroll bar stand out more, or make
> it more clear that there is more to fill in after 'Definition'.

The "Go" button could go to the bottom of the form (it was there until
last week), so that the user is forced to scroll, but I thought that the
disadvantage (scrolling when you don't need to) outweighs the benefits.
I'll have a look at styling scrollbars later, anyway. We'll see if
anything nice comes out of that.

Thanks for your feedback, Dieter.

> Kind regards,
> 
> Dieter
> >> Also my report for this week is available on my blog [3].
> >>
> >> Rouslan
> >>
> >
> > Hi there,
> >
> > This week I got the "Support for Routines" functionality mostly coded
> > in. There are still a few outstanding bugs that I'm aware of, like
> > problems with special characters in routine and parameter names. But
> > other than those and the need for more code refactoring and tidying up,
> > I think that the interface is pretty much finished. If you have time I'd
> > appreciate if you test this functionality out and let me know what you
> > make of it. The demo server [1] and GIT repo [2] are at their usual
> > locations. The report for this week is also available on my blog [3].
> > Thanks for any help.
> >
> > Bye,
> > Rouslan
> >
> > [1]: http://demo.phpmyadmin.net/gsoc-rouslan/
> > [2]: http://repo.or.cz/w/phpmyadmin/roccivic.git/shortlog/refs/heads/rte
> > [3]: http://roccivic.blogspot.com/2011/06/repor-for-week-3.html
> >
> >
> >
> > ------------------------------------------------------------------------------
> > EditLive Enterprise is the world's most technically advanced content
> > authoring tool. Experience the power of Track Changes, Inline Image
> > Editing and ensure content is compliant with Accessibility Checking.
> > http://p.sf.net/sfu/ephox-dev2dev
> > _______________________________________________
> > Phpmyadmin-devel mailing list
> > Phpmyadmin-devel at lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
> >
> 
> 
>