[Phpmyadmin-devel] Column reordering

[Marc Delisle]

Le 2011-06-14 20:29, Aris Feryanto a écrit :
> 
> 
> ----- Original Message -----
>> From: Rouslan Placella <rouslan at placella.com>
>>
>> On Tue, 2011-06-14 at 07:28 -0400, Marc Delisle wrote:
>>>  Aris Feryanto a écrit :
>>>  > 
>>>  > ----- Original Message -----
>>>  >> From: Marc Delisle <marc at infomarc.info>
>>>  >>
>>>  >> Aris Feryanto a écrit :
>>>  >>>  Hi Marc,
>>>  >>>
>>>  >>>  ----- Original Message -----
>>>  >>>>  From: Marc Delisle <marc at infomarc.info>
>>>  >>>>
>>>  >>>>  Le 2011-06-10 23:58, Aris Feryanto a écrit :
>>>  >>>>>   On 10 Jun 2011, at 20:31, Marc Delisle 
>> <marc at infomarc.info> 
>>>  >> wrote:
>>>  >>>>>   I've updated my repo and it should be available 
>> in the demo 
>>>  >> soon. I add 
>>>  >>>>  small popup balloon when we hover the column header. I 
>> also add some 
>>>  >> css code to 
>>>  >>>>  prettify the column dragging. Please kindly check this.
>>>  >>>>>   P.S.: All my changes for column resize and reorder 
>> can be found 
>>>  >> under 
>>>  >>>>  "colresize" branch in my git repo.
>>>  >>>>
>>>  >>>>  Yes, I believe that this is good advertising. Also, 
>> people should
>>>  >>>>  already know how to sort by column so they will discover 
>> the new
>>>  >>>>  dragging pointer and now with the balloon they will know 
>> that it's
>>>  >>>>  possible to drag.
>>>  >>>>
>>>  >>>>  One thing: when the pointer is over the column name and a 
>> click would
>>>  >>>>  sort instead of drag, the balloon still says Click to 
>> drag. The balloon
>>>  >>>>  says something different that the tooltip who is saying 
>> Sort.
>>>  >>>  I suggest changing the text, then. How about "Drag to 
>> reorder" as 
>>>  >> updated in my current git repo?
>>>  >>
>>>  >> The new message and the combined new messages are fine.
>>>  > 
>>>  > Hi,
>>>  > 
>>>  > I added 'Click to mark/unmark' in the popup balloon. You may 
>> check this in my git.
>>>
>>>  Looks nice.
>>>  > 
>>>  >> By the way, the new features under IE 8 (Windows XP) seems to be 
>>>  >> limited, it this expected?
>>>  >>
>>>  >> - no balloons
>>>  >> - no indicator for the destination column when dragging
>>>  >> - column reorder does not work at all
>>>  >>
>>>  >> makegrid.js line 49, expected identified, string or number
>>>  >>
>>>  >> sql.js line 222 character 9, object doesn't support this 
>> property or method
>>>  >>
>>>  > 
>>>  > 
>>>  > Fixed. Thanks for pointing this out, Marc.
>>>
>>>  I confirm the fix.
>>>
>>>  Another thing: when I disable Javascript in my Firefox 4.0.1:
>>>
>>>  - hovering over the column's th should not change the pointer to the 
>>>  dragging 4-arrow pointer
>>>
>>>  - hovering over the column's name should show me the (old) Sort title
>>>
>> The "Restore column order" button shouldn't be there either with 
>> JS
>> disabled ;)
>>
> 
> 
> Hi,
> 
> Fixed in my git. I also noted that the recent tables is not working when javascript is disabled. Will fix this soon.

Aris,
did you push your repo?


-- 
Marc Delisle
http://infomarc.info