[Phpmyadmin-devel] GSoC 2011: Routines functionality is complete

Rouslan Placella rouslan at placella.com
Tue Jun 21 00:21:03 CEST 2011


On Mon, 2011-06-20 at 16:32 -0400, Marc Delisle wrote:
> Rouslan Placella a écrit :
> > On Mon, 2011-06-20 at 15:11 +0100, Rouslan Placella wrote:
> >> On Mon, 2011-06-20 at 16:06 +0200, Michal Čihař wrote:
> >>> Hi
> >>>
> >>> Dne Mon, 20 Jun 2011 14:27:36 +0100
> >>> Rouslan Placella <rouslan at placella.com> napsal(a):
> >>>
> >>>> In my opinion the routines functionality is complete and is ready to be
> >>>> merged with master. I will now be moving on to work on support for
> >>>> events. Please let me know what you think.
> >>> I was just looking at your changes :-). I think it's okay to merge it,
> >>> this will for sure give broader testing to new features and discover
> >>> more bugs :-). Will you do the merge?
> >> OK, thanks for your feedback, I will merge with master some time
> >> today :)
> >>
> >> Rouslan
> > 
> > I merged with master, but since I had some of the trigger and event
> > related code in the same branch, it also leaked into master. I
> > personally don't see a problem with this though. Hope everyone agrees.
> > 
> > Rouslan
> 
> Rouslan,
> about this other code, I suggest you deactivate at least the related menus.

Done.

> About the routines code, please add a ChangeLog entry.

And done (and I'll keep this in mind for next time).

Thanks for your feedback :)

Rouslan





More information about the Developers mailing list