[Phpmyadmin-devel] AJAXify phpMyAdmin Interface - GSOC 2011 - Table->Browse ->Mutiple rows-> Change
Rouslan Placella
rouslan at placella.com
Tue Jun 21 11:19:41 CEST 2011
On Mon, 2011-06-20 at 20:36 +0100, Rouslan Placella wrote:
> On Mon, 2011-06-20 at 23:59 +0530, Thilanka Kaushalya wrote:
> > Hi Marc,
> >
> >
> > On Mon, Jun 20, 2011 at 5:38 PM, Marc Delisle <marc at infomarc.info> wrote:
> >
> > > Thilanka Kaushalya a écrit :
> > > > Hi Marc,
> > > >
> > > > Thanks for testing the modification.
> > > >
> > > > 1. If I'm browsing in vertical mode, the new feature does not work (I
> > > > get "No rows selected").
> > > >
> > > > 2. In js/sql.js, instead of "if(" please use "if (".
> > > >
> > > > 3. Instead of introducing a new message "Change Table", please use
> > > the
> > > > already existing "Change".
> > > >
> > > >
> > > > I fixed those issues and pushed my changes to the repo. Please check
> > > those.
> > > >
> > > > Regards,
> > > > Thilanka.
> > >
> > > Great. Feature merged to origin/master.
> > >
> > >
> > I published the blog post[1] on my work done in 4th week. Sorry for the
> > delay of submitting it and next time 'll put it on Sunday.
> >
> > [1] -
> > http://coders-view.blogspot.com/2011/06/ajaxify-phpmyadmin-interface-gsoc-2011_20.html
>
> I had a quick look at the functionality that you worked on and I noticed
> that the font in the dialog is bigger than in the actual page behind.
> I'm not sure why this is happening, but I this was happening in my code
> as well. To fix this I specified a smaller font-size when creating the
> AJAX dialog. For example:
>
> $ajaxDialog = $('<div style="font-size: 0.9em;">'+data.message
> +'</div>').dialog({ /* options go here */ });
>
> Bye,
> Rouslan
I also noticed that the "Create table" button in the navigation frame
does not a show a "Loading" ajax message when clicked, like the one seen
if you create table from database structure tab.
Rouslan
More information about the Developers
mailing list