[Phpmyadmin-devel] Fieldset CSS

Tyron Madlener tyronx at gmail.com
Wed Jun 22 20:56:20 CEST 2011


On Tue, Jun 21, 2011 at 4:49 PM, Michal Čihař <michal at cihar.com> wrote:
> Hi
>
> Dne Mon, 20 Jun 2011 15:04:02 +0200
> Tyron Madlener <tyronx at gmail.com> napsal(a):
>
>> On Fri, May 20, 2011 at 11:08 AM, Michal Čihař <michal at cihar.com> wrote:
>> > Hi
>> >
>> > Dne Wed, 18 May 2011 19:00:39 +0200
>> > Tyron Madlener <tyronx at gmail.com> napsal(a):
>> >
>> >> pmahomme currently has misaligned checkboxes in fieldsets (i can see
>> >> this in opera, chrome and ie):
>> >>
>> >> http://www.tyron.at/tmp/sql_bookmark1.png
>> >>
>> >> Can we fix this? The best solution I can think of is to remove the
>> >> float of '.formelement' Elements, and instead add 'display:inline'.
>> >> For correct text-reading-direction however, we would need to put a
>> >> <div> element around such form element groups then that contain the
>> >> 'float: <?php echo $left; ?>;'. For the SQL Query page we could reuse
>> >> the div#bookmarkoptions
>> >>  Unfortunately it would require changes in quite a bunch of files
>> >> (which I don't know what they do yet).
>> >>
>> >> The result would be:
>> >>
>> >> http://www.tyron.at/tmp/sql_bookmark2.png
>> >
>> > Mike, can you please check this? I'm no way expert on CSS :-).
>> >
>>
>> Shall I just implement this behavior maybe?
>
> Yes, please go ahead. Mike seems to be not responsible in last days.

Looking at this issue with my small laptop resolution my suggested fix
would put a line break into the checkbox labels which doesn't look
nice.
So for now, I still haven't found a good solution for this.

What I did however, is write a small patch that hides the bookmark
options checkboxes when the label is empty. With the Clear button
removed as well, the UI looks noticeably cleaner.

Patch id is a08bfa3964e43b341d0ae52610148765ae0ca721

>
> --
>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>
> ------------------------------------------------------------------------------
> EditLive Enterprise is the world's most technically advanced content
> authoring tool. Experience the power of Track Changes, Inline Image
> Editing and ensure content is compliant with Accessibility Checking.
> http://p.sf.net/sfu/ephox-dev2dev
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>




More information about the Developers mailing list