[Phpmyadmin-devel] pmahomme: about .data at 100%

[Mike Homme]

Marc,

I now noticed the .data selector is applied to not only the <table> but to
every cell within it. Not sure if that's necessary, and removing it fixes
the 100% problem without having to actually remove the 100% from the CSS.

Here's what I changed: 

On line 1243 - in "display_tbl.lib.php"

>From this:
$class = 'data ' . $inline_edit_class . ' ' . $not_null_class . ' ' .
$alternating_color_class . ' ' . $relation_class;

To this:
$class = $inline_edit_class . ' ' . $not_null_class . ' ' .
$alternating_color_class . ' ' . $relation_class;

Can we try that?

Thanks,
Mike

> -----Original Message-----
> From: Marc Delisle [mailto:marc at infomarc.info]
> Sent: Friday, March 11, 2011 2:35 PM
> To: phpmyadmin-devel at lists.sourceforge.net
> Subject: Re: [Phpmyadmin-devel] pmahomme: about .data at 100%
> 
> Mike Homme a écrit :
> > Hi Mark,
> >
> > I agree with you. There's no upside to it. :)
> >
> > But I've been trying to figure out why it's happening with just
> > integer columns. I haven't explicitly set anything in the theme to
increase
> that.
> 
> Mike,
> I did a quick test: it's not about integer columns, it's about the first
column.
> 
> >
> > I'd like to look at "display_tbl.lib.php" just a bit more before I
> > call it quits and remove the 100% width from the CSS. I'll be sure to
> > commit something tonight. However, if I do find something with the
> > display.lib that will allow us to keep the 100% width and size down
> > the column, I'd like to discuss those options.
> >
> > Thanks,
> > Mike
> >
> > -----Original Message-----
> > From: Marc Delisle [mailto:marc at infomarc.info]
> > Sent: Thursday, March 10, 2011 3:14 PM
> > To: phpmyadmin-devel at lists.sf.net
> > Subject: [Phpmyadmin-devel] pmahomme: about .data at 100%
> >
> > Hi,
> > it's me again with my complaint (on pmahomme theme). I'm back because
> > I got the feedback from colleagues, especially one equipped with a wide
> screen.
> >
> > In this situation, the first data column (when it's a integer) is
> > ridiculously wide, as seen in Firefox. This is a common situation,
> > having an integer as the first column (PK).
> >
> > Maybe I only see the downsides of this setting. What are the upsides?
> >
> 
> --
> Marc Delisle
> http://infomarc.info
> 
>
----------------------------------------------------------------------------
--
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit for your
> organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel