[Phpmyadmin-devel] GSOC Interesting

Sat Mar 19 21:46:55 CET 2011

On Sun, Mar 20, 2011 at 1:56 AM, Andreas Lundquist <andreas.lunkan at gmail.com
> wrote:

> Hi,
>
> If you say so, I just thought it looked weird but I don't know how
> replace() works. Could you describe what the replace function do?
> replace(/ '/g, " ' ' ") + " ' , ";
> I think the first start quotation just before the /g doesn't have any end
> quotation.
>
> Either way, I'm looking for a solution because I get an internal server
> error 500 for my inline editing ajax call to tbl_replace.php when saving.
> I think it's my environment as it works on the latest demo from the wiki
> but I don't know. Maybe someone else has got the same problem.
>
> Regards,
> Andreas
>
>
Hi,

The replace call does nothing wrong, it's just the correct way to include
quote characters within a string in mysql.

--
Regards

Rohit Sharma
CSE
IIIT-Hyderabad <http://iiit.net/>

>
>
> 2011/3/19 rohit sharma <rsedwardian at gmail.com>
>
>> On Sat, Mar 19, 2011 at 11:19 PM, Andreas Lundquist <
>> andreas.lunkan at gmail.com> wrote:
>>
>>> Hi Dieter,
>>>
>>> Thanks. Don't know if this is the right place but I think I found a bug
>>> in inline editing of rows. The save button don't work like it should and
>>> when I looked through
>>> the code I found a strange looking line. sql_query += ' `' + field_name +
>>> "`='" + this_field_params[field_name].replace(/'/g, "''") + "' , ";
>>> This is line 842 in js/sql.js.
>>>
>>> I don't know how the end on that line should look but it's definitely not
>>> right with the quotations. Should I add a bug to the tracker about this and
>>> try to fix it?
>>>
>>> Kind regards,
>>> Andreas
>>>
>>>
>> Hi,
>>
>> What's wrong with the quotes, it loops over and collects all the fields,
>> then trims the sql query for the additional "," that is appended for the
>> last column.
>>
>> --
>> Rohit Sharma
>> CSE
>> IIIT-Hyderabad <http://iiit.net/>
>>
>>
>>>
>>>
>>> 2011/3/19 Dieter Adriaenssens <dieter.adriaenssens at gmail.com>
>>>
>>>> 2011/3/19 Lunkan <andreas.lunkan at gmail.com>:
>>>> > Hi pma developing community!
>>>> > First of all, a small presentation, my name is Andreas Lundquist and
>>>> is a
>>>> > pre-graduate student from Sweden. I have been using phpmyadmin a lot
>>>> when
>>>> > doing things like small websites and so.
>>>> > It's always been my first choice when doing web development.
>>>> > I'm interested in the idea of improving the browse-mode like said on
>>>> the
>>>> > idea page
>>>> > at
>>>> http://wiki.phpmyadmin.net/pma/GSoC_2011_Ideas_List#Browse-mode_improvements
>>>> .
>>>> > There were quite many users who have sent in requests about this topic
>>>> and
>>>> > many of them I think are possible to implement.
>>>> > Sadly I have never contributed to any open-source projects before so
>>>> this
>>>> > mailinglist and stuff like git is quite new for me. However I have
>>>> been
>>>> > using svn on some projects so I'm not to blown away of the idea.
>>>> > I have managed to get the source code to a local git repository and
>>>> will
>>>> > create a repository on the site recommended by the git guide in the
>>>> wiki.
>>>> > I will look through the source code and hopefully understand the
>>>> structure
>>>> > and try to fix some bugs or requests from the bug tracker so I get the
>>>> idea
>>>> > of sending in code to be reviewed.
>>>> > Just one question though just to be clear, am I supposed to write a
>>>> line in
>>>> > the bug tracker before I start try to implement it even if I'm not
>>>> sure I
>>>> > could do it?
>>>> > That's all for now, just thought I should present myself to the
>>>> community so
>>>> > you know who I am.
>>>> >
>>>> > Best regards,
>>>> > Andreas Lundquist
>>>> >
>>>>
>>>> Hi Andreas,
>>>>
>>>> Thanks for the elaborate introduction. Welcome on the mailing list.
>>>>
>>>> To answer your question about the bug/feature tracker : it is always a
>>>> good idea to let others know you are working on a patch, to avoid that
>>>> two or more people are working on the same patch.
>>>>
>>>> But I guess before you start working on a patch, you reviewed the bug,
>>>> tried to reproduce it and looked for the problem in order to get an
>>>> idea on how to solve it, so by that time you should know if you will
>>>> be able to fix it. ;)
>>>>
>>>> In the case you stop working on it, or don't plan to finish it, add
>>>> another comment that you're not working on it anymore, so that others
>>>> can work on it.
>>>>
>>>> Good luck with GSoC (and submitting your proposal).
>>>>
>>>> Kind regards,
>>>>
>>>> Dieter
>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> Colocation vs. Managed Hosting
>>>> A question and answer guide to determining the best fit
>>>> for your organization - today and in the future.
>>>> http://p.sf.net/sfu/internap-sfd2d
>>>> _______________________________________________
>>>> Phpmyadmin-devel mailing list
>>>> Phpmyadmin-devel at lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>>
>>>
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Colocation vs. Managed Hosting
>>> A question and answer guide to determining the best fit
>>> for your organization - today and in the future.
>>> http://p.sf.net/sfu/internap-sfd2d
>>> _______________________________________________
>>> Phpmyadmin-devel mailing list
>>> Phpmyadmin-devel at lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>>
>>>
>>
>>
>> --
>> *Baby, Why not smile?  *
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Colocation vs. Managed Hosting
>> A question and answer guide to determining the best fit
>> for your organization - today and in the future.
>> http://p.sf.net/sfu/internap-sfd2d
>> _______________________________________________
>> Phpmyadmin-devel mailing list
>> Phpmyadmin-devel at lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>>
>>
>
>
> ------------------------------------------------------------------------------
> Colocation vs. Managed Hosting
> A question and answer guide to determining the best fit
> for your organization - today and in the future.
> http://p.sf.net/sfu/internap-sfd2d
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20110320/54ffbddc/attachment.html>