[Phpmyadmin-devel] Patch: Copy set of tables to new name pattern

[Marc Delisle]

陈岳峰 a écrit :
> hi,
> I have made patch for that.Check it on my git .

(Please do not top-post. It's better to write your answer after my
question in your reply.)

Ok, the warnings are gone but there is still the problem of not being
warned if the target tables already exist.

> 
> Thannks.
> 
> Dennis Chen
> 
> On 3/20/11, Marc Delisle <marc at infomarc.info> wrote:
>> Le 2011-03-18 03:43, 陈岳峰 a écrit :
>>> Hi,
>>>
>>> I have made a patch for
>>>
>>>     Copy set of tables to new name pattern - ID: 1863198
>>>
>>> Please check it on http://repo.or.cz/r/phpmyadmin/dennischen.git/
>>>
>>> Thanks
>>>
>>> Dennis Chen
>> Dennis,
>>
>> Going to database / Operations (my phpMyAdmin is set to display errors)
>> and I see these warnings:
>>
>> Warning in ./libraries/common.lib.php#2475
>> Missing argument 3 for PMA_display_html_checkbox(), called in
>> db_operations.php on line 638
>>
>> Backtrace
>>
>> ./db_operations.php#638: PMA_display_html_checkbox(
>> string replace_replicated_table,
>> string Replace Replicated Tables,
>> )
>> Warning in ./libraries/common.lib.php#2475
>> Missing argument 4 for PMA_display_html_checkbox(), called in
>> db_operations.php on line 638 and defined
>>
>> Backtrace
>>
>> ./db_operations.php#638: PMA_display_html_checkbox(
>> string replace_replicated_table,
>> string Replace Replicated Tables,
>> )
>> Notice in ./libraries/common.lib.php#2477
>>
>> Undefined variable: checked
>>
>> Backtrace
>>
>> ./db_operations.php#638: PMA_display_html_checkbox(
>> string replace_replicated_table,
>> string Replace Replicated Tables,
>> )
>> Notice in ./libraries/common.lib.php#2477
>>
>> Undefined variable: onclick
>>
>> Backtrace
>>
>> ./db_operations.php#638: PMA_display_html_checkbox(
>> string replace_replicated_table,
>> string Replace Replicated Tables,
>> )
>> ==========
>>
>> Then I proceed with a copy operation, by prefix. It seems to go well,
>> but again I get some warnings:
>>
>> Notice in ./db_operations.php#74
>> Undefined variable: replace_replicated_table
>>
>> Notice in ./db_operations.php#90
>> Undefined variable: replace_replicated_table
>>
>> Notice in ./db_operations.php#101
>> Undefined variable: replace_replicated_table
>>
>> Notice in ./db_operations.php#377
>> Undefined variable: newname
>>
>> =========
>> Also, copying to existing prefix, I get "No operations", the message
>> could be more explicit.



-- 
Marc Delisle
http://infomarc.info