[Phpmyadmin-devel] Recently Used Tables

[Marc Delisle]

Le 2011-05-07 20:53, Aris Feryanto a écrit :
> Hi all,
> 
> I've pushed commits improving the "recently used tables" in my repo and would like to ask for comments before I proceed further.
> 
> The demo have been updated, so you can try it through [0]. What I've done so far:
> 
> - Added configuration 'LeftRecentTable' ("Settings" -> "Navigation frame" -> "Navigation frame" tab -> "Recently used tables")
> - Added a new class ./libraries/RecentTable.class.php for managing recent tables
> - Added configuration ['Servers'][$i]['recent'], table in pma database for "persistent" recent tables
> - Added SQL commands to create 'pma_recent' table in scripts/create_tables.sql
> 
> others:
> - Added 'recent' feature in ./libraries/relation.lib.php
> - Modified some CSS to prettify navigation frame
> 
> What next to be done:
> 
> - Write documentation about configuration LeftRecentTable
> - Write documentation about table pma_recent in Documentation.html
> 
> 
> [0] http://demo.phpmyadmin.net/gsoc-aris/
> 
> 
> Regards,
> --
> Aris Feryanto

Hi Aris,

On the positive side, the new feature works well, both with or without
pma_recent.

On the negative side, I can no longer browse any table (no data is shown
and there are warnings at the bottom of the browse page).

Missing feature:
- in /setup I don't see how to define pma_recent

Suggestions:
- in saveToDb() you could use REPLACE INTO instead of a SELECT then
UPDATE or INSERT, see http://dev.mysql.com/doc/refman/5.1/en/replace.html

- in getHtmlSelect() please use jQuery instead of the onchange event;
this is the direction we are taking about js in this project

- about syntax, please write "if (! isset" instead of "if (!isset" (add
a space after the exclamation point)

Keep up the good work.

-- 
Marc Delisle
http://infomarc.info