[Phpmyadmin-devel] PMA_DBI_get_columns/fields - which is deprecated?

[Marc Delisle]

Le 2011-05-19 16:41, Dieter Adriaenssens a écrit :
> 2011/5/19 Piotr Przybylski <piotr.prz at gmail.com>:
>> 2011/5/19 Dieter Adriaenssens <dieter.adriaenssens at gmail.com>:
>>> 2011/5/19 Marc Delisle <marc at infomarc.info>:
>>>> Piotr Przybylski a écrit :
>>>>> 2011/5/19 Dieter Adriaenssens <dieter.adriaenssens at gmail.com>:
>>>>>> 2011/5/19 Crack <piotrprz at gmail.com>:
>>>>>>> 2011/5/19 Dieter Adriaenssens <dieter.adriaenssens at gmail.com>:
>>>>>>>
>>>>>>>> commit 9c170511179
>>>>>>>>
>>>>>>>> I'm not sure about replacing the obsolete function. I remember Marc
>>>>>>>> telling something about not using 'columns' but 'fields', last summer,
>>>>>>>> so I guess removing the function is a move in the opposite direction.
>>>>>>>> Can you check on the developers mailing list what should be done with
>>>>>>>> this function?
>>>>>>> In code comments I saw 'fields' marked as deprecated [1], with
>>>>>>> function's comment telling me to use one of 'columns' variants...
>>>>>> Yes, I noticed the 'deprecated' status too, but seeing it I remembered
>>>>>> Marc's comment, so I started wondering if this deprecation, or at
>>>>>> least the function name, is still correct.
>>>>>>
>>>>>>> [1] http://repo.or.cz/w/phpmyadmin/crack.git/blobdiff/7d3cd879a496adc27e5e827ef3e35f7633a827de..9c170511179a721198527f063a58ab1b031b1b93:/libraries/database_interface.lib.php
>>>>>>>
>>>>>
>>>>> Going public with this, maybe someone will remember :)
>>>>>
>>>>
>>>> The move we made was to replace the non-standard term "field" with the
>>>> standard SQL term "column" on the interface.
>>>
>>> I found the mail I remembered [0] and apparently misinterpreted it :
>>> rows and columns it is then. ;)
>>>
>>> [0] http://sourceforge.net/mailarchive/message.php?msg_id=25405157
>>>
>>
>> Good, so I removed the right function :)
>  :)
> 
> I'll merge it [1] with master. This seems something that can already
> benefit the project. Objections?

OK for me.
> 
> [1] http://repo.or.cz/w/phpmyadmin/crack.git/commit/9c170511179a721198527f063a58ab1b031b1b93


-- 
Marc Delisle
http://infomarc.info