[Phpmyadmin-devel] First day of GSoC work

[Piotr Przybylski]

2011/5/23 Rouslan Placella <rouslan at placella.com>:
> On Sun, 2011-05-22 at 21:33 +0200, Piotr Przybylski wrote:
>> 2011/5/22 Rouslan Placella <rouslan at placella.com>:
>> > Hi there,
>> >
>> > I started coding for GSoC yesterday, since I need Monday off for a
>> > college exam. I pushed the changes that I did to my repo [1], and they
>> > are available for you to try on my demo server [2] (There are some
>> > routines and triggers in the sakila db, but you'll have to add your own
>> > events). Well, first of all I'd appreciate any feedback from you guys
>> > regarding what I did. Which was: adding tabs for routines, triggers,
>> > events; moving there the functionality that was already available;
>> > getting export and drop options to work properly. However I have a
>> > problem with the "Drop" option that doesn't redirect the user back to
>> > where he came from after deleting the requested object. I tried adding a
>> > "goto" variable to $urlquery, but by the time that the user is taken to
>> > sql.php, "goto" simply disappears. I'm not sure what I'm missing. Any
>> > clues?
>> >
>> > Thanks,
>> > Rouslan
>> >
>> > [1]: http://repo.or.cz/w/phpmyadmin/roccivic.git
>> > [2]: http://demo.phpmyadmin.net/gsoc-rouslan/
>>
>> I think you should join Time and Event columns in Triggers tab, they
>> are usually thought of as one thing.
>>
>> Please don't show Events, Triggers and Routines tabs for Drizzle
>> (check PMA_DRIZZLE constant) - none of these is currently supported.
>>
>
> Hey Piotr,
>
> thanks for your comments. I'll make sure to hide these features for
> Drizzle users. I take it that the PMA_DRIZZLE constant is already
> available as of 3.4.0.

Yes, it's available.

> As far as joining the Time and Event columns, I didn't code that list
> myself, so I just left it as it was. Besides I think that I'll be
> displaying these parameters separately in the event editor, so to me it
> makes sense to keep them separate also in the list of events.
>

-- 
Piotr Przybylski