[Phpmyadmin-devel] 3 patch suggestions for master

[Tyron Madlener]

On Tue, May 31, 2011 at 1:38 PM, Michal Čihař <michal at cihar.com> wrote:
> Hi
>
> Dne Tue, 31 May 2011 11:54:17 +0200
> Tyron Madlener <tyronx at gmail.com> napsal(a):
>
>> On Tue, May 31, 2011 at 10:51 AM, Michal Čihař <michal at cihar.com> wrote:
>> >Er, actually not, because you should display 0 when then value is 0 and
>> >not <1 in such case.
>>
>> You mean for values without comma? Are there cases where such behavior
>> is required in pma?
>
> I mean when there is 0 as a value, for example in status variables,
> let's say Com_alter_db_upgrade or all Ssl_* variables if ssl is not
> being used. In such case displaying 0 is right thing to do, but not <1
> as your patch does.
>

Oh yes, thats not right. Commit
226ca36c9cfa6f15b79ec058f92bc5c36675541f fixes that

Here's a patch that includes both commits:
http://www.tyron.at/tmp/number_format.diff

> --
>        Michal Čihař | http://cihar.com | http://blog.cihar.com
>
> ------------------------------------------------------------------------------
> Simplify data backup and recovery for your virtual environment with vRanger.
> Installation's a snap, and flexible recovery options mean your data is safe,
> secure and there when you need it. Data protection magic?
> Nope - It's vRanger. Get your free trial download today.
> http://p.sf.net/sfu/quest-sfdev2dev
> _______________________________________________
> Phpmyadmin-devel mailing list
> Phpmyadmin-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/phpmyadmin-devel
>
>