[Phpmyadmin-devel] makegrid.js help

[Marc Delisle]

Le 2011-11-06 20:16, Aris Feryanto a écrit :
> 
> On 6 Nov, 2011, at 8:51 PM, Rouslan Placella <rouslan at placella.com> wrote:
> 
>> On Sun, 2011-11-06 at 06:54 -0500, Marc Delisle wrote:
>>> Hi,
>>>
>>> I would appreciate help about one display issue. In QA_3_4, browsing
>>> sakila.actor with Firefox 7.0.1 (tested on Vista) shows vertical solid
>>> lines at the right of each data column. This is the expected behavior,
>>> produced by
>>>
>>> #table_results td.data {
>>> border-right: 1px solid #444444;
>>> }
>>>
>>> However in master, the lines appear then disappear. It happens somewhere
>>> in makegrid.js.
>>>
>>
>> Hi Marc,
>>
>> the issue is that each table column is overlayed with a div element and
>> they have conflicting border-right CSS declarations. Fix below, adjust
>> it as you see fit, if needed.
>>
>> http://repo.or.cz/w/phpmyadmin/roccivic.git/commitdiff/4d1e6f302f04543ce1fea0524d3d8179ee894d21
>>
>> Or pull from branch "colborder" of
>> git://repo.or.cz/phpmyadmin/roccivic.git

Thanks Rouslan, I'll check your patch today.

>>
> 
> 
> Hi all,
> 
> Yes, exactly as what have been written by Rouslan. The dark borders conflicts with
> the white borders for column resizing. The commit above should fix that.
> 
> But, in my opinion, the dark border for pmahomme theme looks a bit odd.

I have added this line on the right side, to help see where each
vertical column starts and ends. See [0]. After reading this bug report,
I realized that I was also annoyed by this lack of visual column separation.

Opinions on this?

[0]
http://sourceforge.net/tracker/?func=detail&aid=3426836&group_id=23067&atid=377408


-- 
Marc Delisle
http://infomarc.info