[Phpmyadmin-devel] Improved index editor

[Dieter Adriaenssens]

2011/11/15 Rouslan Placella <rouslan at placella.com>:
> On Tue, 2011-11-15 at 15:20 -0500, Marc Delisle wrote:
>> Rouslan Placella a écrit :
>> > On Tue, 2011-11-15 at 12:22 -0500, Marc Delisle wrote:
>> >> Rouslan Placella a écrit :
>> >>> Hi all,
>> >>>
>> >>> I did some work on the "table properties" page and, in particular, on
>> >>> the index editor. As a result, I now have a branch with several
>> >>> improvements and fixes. I would like to merge with master within the
>> >>> next few days, unless there are some objections.
>> >>>
>> >>> Fixes:
>> >>> * Fix for indexes list that did not respect $cfg['InitialSlidersState']
>> >>> * Removed some redundant data from AJAX replies
>> >>> * "Add columns" action only worked when the English language was used
>> >>>
>> >>> Features:
>> >>> * AJAXified the "create index" action (not sure why this wasn't done)
>> >>> * Tidied up the layout at the bottom of the table structure page with
>> >>> some fieldsets
>> >>>
>> >>> * Index editor:
>> >>> Some issues with the old implementation of the index editor are:
>> >>> It was using up way too much horizontal space (900px), by tidying up the
>> >>> layout of the editor, I brought this down to 450px. I converted the
>> >>> "primary key warning" into a tooltip to gain a bit of vertical space.
>> >>> Then there was an issue when a user requested to add a column to the
>> >>> index editor: the browser fired an HTTP request of the form to the
>> >>> server, just to get the same form back with an extra empty field. Of
>> >>> course, this action can be done on the client side by just cloning a row
>> >>> from the table.
>> >>>
>> >>> Anyway, there are some low-quality screenshots attached. You can also
>> >>> pull from the "indexes" branch of
>> >>> git://repo.or.cz/phpmyadmin/roccivic.git
>> >>>
>> >>> And, your feedback is very welcome :)
>> >> Hi Rouslan,
>> >> this is a welcome improvement to the structure page and index editor.
>> >> However there is one case that needs handling. If the creation of a
>> >> unique index generates a duplicate key error, the user is not warned and
>> >> the "Add index" panel remains there.
>> >
>> > That was actually an unrelated bug, introduced with the sticky menu bar.
>> > I fixed that in master.
>>
>> Great; please look at this screenshot for a weird display in IE 8 /
>> Windows XP.
>
> I can't reproduce this issue in IE 8 / Windows 7. Could you look into
> it? Maybe it's the browser cache?

I'll try to reproduce this tomorrow or Thursday. I have a similar
setup on my laptop at work.

Kind regards,

Dieter