[Phpmyadmin-devel] Cancel button in Create table dialog

[Marc Delisle]

Le 2011-10-13 04:32, Dieter Adriaenssens a écrit :
> 2011/10/12 Piotr Przybylski <piotr.prz at gmail.com>:
>> 2011/10/12 Marc Delisle <marc at infomarc.info>:
>>> Piotr Przybylski a écrit :
>>>> 2011/10/11 Marc Delisle <marc at infomarc.info>:
>>>>> Hi,
>>>>> we don't need this Cancel button at the bottom, if we keep the title bar
>>>>> which contains an X control, correct?
>>>>
>>>> Yes, but then we should add "Cancel" next to "Save" button. I'm all
>>>> for that, in this case more vertical space will be useful - we'll get
>>>> less scrollbars.
>>>>
>>>
>>> I'm not sure I follow you. Why the need for a Cancel button, when the
>>> top X can do the job?
>>
>> Because user interfaces are usually built that way - "Cancel" is
>> expected to be somewhere near "Save", especially if you have a special
>> area for buttons. X is not that obvious.
> 
> I agree,

Please have a look at my commit
301f8d981a817741a29514e4757b95ab342d279c. It works except that after
adding columns, the Cancel button is no longer there.


-- 
Marc Delisle
http://infomarc.info