[Phpmyadmin-devel] New sprites implementation

[Rouslan Placella]

On Sun, 2011-10-02 at 06:23 -0400, Marc Delisle wrote:
> Le 2011-10-01 08:01, Rouslan Placella a écrit :
> > On Sat, 2011-10-01 at 06:54 -0400, Marc Delisle wrote:
> >> Le 2011-09-30 14:59, Rouslan Placella a écrit :
> >>> Hi there,
> >>>
> >>> I've just pushed the new sprites implementation to master and updated
> >>> the relevant wiki page [1]. Please take the time to read this
> >>> documentation. Thank you.
> >>>
> >>> If you have any feedback on the matter, I'd love to hear it.
> >>>
> >>> Rouslan
> >>>
> >>> [1]: http://wiki.phpmyadmin.net/pma/Icons/Sprites_Usage
> >>
> >> Rouslan,
> >> after using generate_sprites, all my icons now have a black background.
> >> Maybe this is related to the numerous errors I get, such as:
> >>
> >> identify: invalid colormap index `s_vars.png' @
> >> error/image.c/SyncImage/3899.
> > 
> > Hi Marc,
> > 
> > Well, that's not good. Although I doubt that the errors from 'identify'
> > have anything to do with the issue, since that program is only used to
> > extract the height and width from image files. Do you get any errors
> > from 'convert'?
> > 
> > Anyway, under what OS were you running the script? What does "convert
> > --version" say? Also can you run the below commands and let me know what
> > the output is and what the resulting images look like?
> 
> Version: ImageMagick 6.6.1-5 2010-04-28 Q16 http://www.imagemagick.org
> 
> > 
> > cd /path/to/phpmyadmin/
> > convert -size 16x16 xc:none test1.png
> > convert test1.png themes/pmahomme/img/b_drop.png -composite test2.png
> > identify -ping test1.png
> 
> test1.png PNG 16x16 16x16+0+0 16-bit PseudoClass 65536c 229B 0.000u 0:00.000
> 
> > identify -ping test2.png
> 
> test2.png PNG 16x16 16x16+0+0 16-bit DirectClass 1.31KB 0.000u 0:00.000

But what do test1.png and test2.png look like? Do they have a black
background or a transparent one?

> > Thanks.
> > 
> > Rouslan