[Phpmyadmin-devel] Dynamically increasing Create table dialog's size

[Rouslan Placella]

On Tue, 2011-10-11 at 01:57 +0200, Piotr Przybylski wrote:
> 2011/10/11 Rouslan Placella <rouslan at placella.com>:
> > On Mon, 2011-10-10 at 22:42 +0200, Piotr Przybylski wrote:
> >> It still caused scrollbars to appear, so I tried to change Marc's
> >> approach - now window's scrollbars should be inactive, only dialog's
> >> content should have them [1]. While at it, I also upgraded jQuery UI
> >> to the newest stable version [2].
> >
> > I'm not convinced that this is better. Try the following scenario:
> > * Open a somewhat small browser window.
> > * Click Create table.
> > * Maximise the browser window.
> > The dialog remains the same size, is padded with a lot of white space
> > and there is no way to resize it, so the user has to close and reopen
> > it. Same goes for making the browser window smaller after opening the
> > dialog: you can't resize it, so you end up with two sets of scrollbars
> > anyway.
> 
> What browser are you using? There is a callback that should be
> reacting to window's resize.

So far I tried (under linux): Firefox 7, Opera 11 and Chromium 12. The
issue is present in all of them. I also tried IE8, where it doesn't seem
to work at all. Clicking the create table icon opens an unusable dialog.
See attached screenshot.

> >> I hope I didn't break anything in the process, and that new dialog works better.
> >>
> >> [1] http://phpmyadmin.git.sourceforge.net/git/gitweb.cgi?p=phpmyadmin/phpmyadmin;a=commitdiff;h=d424a797d5dd9e25a3c4a0923d45efdcf9005981
> >> [2] http://phpmyadmin.git.sourceforge.net/git/gitweb.cgi?p=phpmyadmin/phpmyadmin;a=commitdiff;h=ac365e0262fa2323dc830bb563e8e97de3694781
> >
> > Also I'm not sure why you committed the following:
> >
> > --- a/js/functions.js
> > +++ b/js/functions.js
> > @@ -1433,6 +1433,8 @@ function PMA_ajaxRemoveMessage($this_msgbox)
> >             // due to a bug in qtip's implementation we can
> >             // only hide it without throwing JS errors.
> >             $this_msgbox.qtip('hide');
> > +        } else {
> > +            $this_msgbox.remove();
> >         }
> >     }
> >  }
> >
> > This change looks irrelevant to your work and besides the messages are
> > destroyed at line 1388 via a callback, so this change may cause
> > conflicts though I haven't verified this.
> 
> Unless I misunderstood something this should destroy message
> completely, and I needed this change because the way in which I am
> hiding page's content makes recent AJAX message to come back when I
> close create table dialog. It's in the same commit as dialog's change
> for easy rollback.

Sorry about that comment, I see now what that does.

Rouslan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot.png
Type: image/png
Size: 28508 bytes
Desc: not available
URL: <http://lists.phpmyadmin.net/pipermail/developers/attachments/20111011/791d79d7/attachment.png>